Add integration tests for config sensitive masking in airflowctl#61105
Merged
bugraoz93 merged 5 commits intoapache:mainfrom Feb 11, 2026
Merged
Conversation
Subham-KRLX
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
kaxil and
potiuk
as code owners
Member
|
Some static checks fail |
bugraoz93
reviewed
Jan 31, 2026
airflow-ctl-tests/tests/airflowctl_tests/test_config_sensitive_masking.py
Outdated
Show resolved
Hide resolved
Subham-KRLX
force-pushed
the
test/airflowctl-config-masking-integration
branch
from
64b0f52 to
2410823
Compare
Contributor
Author
|
@bugraoz93 @potiuk Refactoring complete. I have cleaned up the code duplication by moving shared logic to conftest.py as suggested. I have verified that the end-to-end masking tests still pass and static checks are green Please merge this PR when you have a moment. |
bugraoz93
force-pushed
the
test/airflowctl-config-masking-integration
branch
from
9b71672 to
9bff783
Compare
bugraoz93
approved these changes
Feb 7, 2026
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Looks good! Thanks! Rebased to see the CI then we can merge :)
Contributor
|
This way, we prevented the test file from getting bigger and bigger for specific use cases. We will also be able to add more with a few lines |
bugraoz93
added
the
full tests needed
bugraoz93
reviewed
Feb 7, 2026
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Have you run the integration test with breeze? I saw your test hasn't picked up by CI so I assume we should add something to somewhere else. This check gives confidence to our releases so we should ensure it rans. Could you please check? We are using pytest so I suspect pytest hasn't picked up because infra looks okay for command test and others
https://github.com/apache/airflow/actions/runs/21778855360/job/62840600175?pr=61105
airflow-ctl-tests/tests/airflowctl_tests/test_config_sensitive_masking.py
Outdated
Show resolved
Hide resolved
…scovery - Remove @pytest.mark.flaky decorator from test_config_sensitive_masking.py as suggested - Fix CI test discovery by changing hardcoded path in run_tests.py from 'test_airflowctl_commands.py' to 'airflowctl_tests' directory to allow pytest to discover all test files in the directory
Subham-KRLX
requested review from
ephraimbuddy,
jedcunningham and
jscheffl
as code owners
Alok-kumar-priyadarshi
pushed a commit
to Alok-kumar-priyadarshi/airflow
that referenced
this pull request
Feb 11, 2026
…che#61105) * Add integration tests for config sensitive masking in airflowctl * Fix static check failures: Sort imports in test_config_sensitive_masking.py * Refactor integration tests to reduce duplication by moving shared logic to conftest.py * Fix static checks in conftest.py * Address PR review feedback: Remove flaky decorator and fix CI test discovery - Remove @pytest.mark.flaky decorator from test_config_sensitive_masking.py as suggested - Fix CI test discovery by changing hardcoded path in run_tests.py from 'test_airflowctl_commands.py' to 'airflowctl_tests' directory to allow pytest to discover all test files in the directory
Ratasa143
pushed a commit
to Ratasa143/airflow
that referenced
this pull request
Feb 15, 2026
…che#61105) * Add integration tests for config sensitive masking in airflowctl * Fix static check failures: Sort imports in test_config_sensitive_masking.py * Refactor integration tests to reduce duplication by moving shared logic to conftest.py * Fix static checks in conftest.py * Address PR review feedback: Remove flaky decorator and fix CI test discovery - Remove @pytest.mark.flaky decorator from test_config_sensitive_masking.py as suggested - Fix CI test discovery by changing hardcoded path in run_tests.py from 'test_airflowctl_commands.py' to 'airflowctl_tests' directory to allow pytest to discover all test files in the directory
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Feb 22, 2026
…che#61105) * Add integration tests for config sensitive masking in airflowctl * Fix static check failures: Sort imports in test_config_sensitive_masking.py * Refactor integration tests to reduce duplication by moving shared logic to conftest.py * Fix static checks in conftest.py * Address PR review feedback: Remove flaky decorator and fix CI test discovery - Remove @pytest.mark.flaky decorator from test_config_sensitive_masking.py as suggested - Fix CI test discovery by changing hardcoded path in run_tests.py from 'test_airflowctl_commands.py' to 'airflowctl_tests' directory to allow pytest to discover all test files in the directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added integration tests to verify sensitive config values are properly masked end-to-end when using airflowctl with actual Airflow API.
The Airflow API masks sensitive values (like
fernet_key,sql_alchemy_conn) as< hidden >. These integration tests confirm that airflowctl correctly preserves and displays those masked values in real scenarios.Changes
config listcommandconfig getforfernet_keyconfig getforsql_alchemy_conn< hidden >appears in output for sensitive configsRelated PRs
Related Issue
Closes #59843
Testing
# Run from airflow-ctl-tests directory pytest tests/airflowctl_tests/test_config_sensitive_masking.py -v